[DBShardGroup] Update handler with tagOnCreate, enable computeRedunda…

…ncy on updates and refactor for simpler stabilization cr: https://code.amazon.com/reviews/CR-154713945
aws-cloudformation · Nov 8, 2024 · 93c4015 · 93c4015
1 parent d8a90ed
commit 93c4015
Show file tree

Hide file tree

Showing 13 changed files with 438 additions and 431 deletions.
diff --git a/aws-rds-dbshardgroup/aws-rds-dbshardgroup.json b/aws-rds-dbshardgroup/aws-rds-dbshardgroup.json
@@ -9,7 +9,7 @@
       "rds:RemoveTagsFromResource"
     ],
     "taggable": true,
-    "tagOnCreate": false,
+    "tagOnCreate": true,
     "tagUpdatable": true,
     "tagProperty": "/properties/Tags"
   },
@@ -32,6 +32,7 @@
     },
     "ComputeRedundancy": {
       "description": "Specifies whether to create standby instances for the DB shard group.",
+      "minimum": 0,
       "type": "integer"
     },
     "MaxACU": {
@@ -95,7 +96,6 @@
     "MaxACU"
   ],
   "createOnlyProperties": [
-    "/properties/ComputeRedundancy",
     "/properties/DBClusterIdentifier",
     "/properties/DBShardGroupIdentifier",
     "/properties/PubliclyAccessible"

diff --git a/aws-rds-dbshardgroup/docs/README.md b/aws-rds-dbshardgroup/docs/README.md
@@ -76,7 +76,7 @@ _Required_: No
 
 _Type_: Integer
 
-_Update requires_: [Replacement](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/using-cfn-updating-stacks-update-behaviors.html#update-replacement)
+_Update requires_: [No interruption](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/using-cfn-updating-stacks-update-behaviors.html#update-no-interrupt)
 
 #### MaxACU
 

diff --git a/aws-rds-dbshardgroup/pom.xml b/aws-rds-dbshardgroup/pom.xml
@@ -21,6 +21,16 @@
     </properties>
 
     <dependencies>
+        <dependency>
+            <groupId>org.apache.commons</groupId>
+            <artifactId>commons-lang3</artifactId>
+            <version>3.12.0</version>
+        </dependency>
+        <dependency>
+            <groupId>software.amazon.rds.common</groupId>
+            <artifactId>aws-rds-cfn-common</artifactId>
+            <version>1.0</version>
+        </dependency>
         <dependency>
             <groupId>software.amazon.awssdk</groupId>
             <artifactId>rds</artifactId>
@@ -36,10 +46,15 @@
         <dependency>
             <groupId>org.projectlombok</groupId>
             <artifactId>lombok</artifactId>
-            <version>1.18.22</version>
+            <version>${org.projectlombok.version}</version>
             <scope>provided</scope>
         </dependency>
-
+        <!-- https://mvnrepository.com/artifact/software.amazon.awssdk/aws-query-protocol -->
+        <dependency>
+            <groupId>software.amazon.awssdk</groupId>
+            <artifactId>aws-query-protocol</artifactId>
+            <version>2.20.138</version>
+        </dependency>
         <!-- https://mvnrepository.com/artifact/org.assertj/assertj-core -->
         <dependency>
             <groupId>org.assertj</groupId>
@@ -68,12 +83,6 @@
             <version>4.3.1</version>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>software.amazon.rds.common</groupId>
-            <artifactId>aws-rds-cfn-common</artifactId>
-            <version>1.0</version>
-            <scope>compile</scope>
-        </dependency>
         <dependency>
             <groupId>software.amazon.rds.common</groupId>
             <artifactId>aws-rds-cfn-test-common</artifactId>
@@ -89,6 +98,15 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>3.12.1</version>
                 <configuration>
+                    <source>${java.version}</source>
+                    <target>${java.version}</target>
+                    <annotationProcessorPaths>
+                        <path>
+                            <groupId>org.projectlombok</groupId>
+                            <artifactId>lombok</artifactId>
+                            <version>${org.projectlombok.version}</version>
+                        </path>
+                    </annotationProcessorPaths>
                     <compilerArgs>
                         <arg>-Xlint:all,-options,-processing</arg>
                     </compilerArgs>
@@ -97,7 +115,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
-                <version>2.3</version>
+                <version>3.2.4</version>
                 <configuration>
                     <createDependencyReducedPom>false</createDependencyReducedPom>
                 </configuration>
@@ -154,6 +172,7 @@
                 <version>2.4</version>
             </plugin>
             <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>
                 <version>3.0.0-M3</version>
             </plugin>