Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle provider options as in the spec. #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dw-kihara
Copy link
Contributor

@dw-kihara dw-kihara commented May 24, 2024

As mentioned in issue #70, there is confusion around the aws_credentials_provider:options() type and usage.
I propose introducing the aws_credentials_provider:provider_specific_options() type and passing it to each provider.

Additionally, I suggest two special options that are treated as "common options" for compatibility with current aws_credentials_file users.
I think there are three choices for handling this:

  1. Introduce more "common options" in the future if needed.
  2. Prohibit any further "common options," keeping them only for compatibility. (my current code)
  3. Remove "common options," breaking compatibility.

I prefer option 3 if breaking compatibility is allowed.
I would appreciate your opinions in the comments. 🙇

@dw-kihara
Copy link
Contributor Author

I realized that the word provider_options is uesd in the aws_credential application env.
So I renamed the provider_options() type to provider_specific_options() in order to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant