Handle provider options as in the spec. #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #70, there is confusion around the
aws_credentials_provider:options()
type and usage.I propose introducing the
aws_credentials_provider:provider_specific_options()
type and passing it to each provider.Additionally, I suggest two special options that are treated as "common options" for compatibility with current aws_credentials_file users.
I think there are three choices for handling this:
I prefer option 3 if breaking compatibility is allowed.
I would appreciate your opinions in the comments. 🙇