Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #103: Migrate from aws-sdk-go to aws-sdk-go-v2 #104

Merged

Commits on Mar 8, 2024

  1. Issue #103: Migrate from aws-sdk-go to aws-sdk-go-v2

    Goal here has been to minimize the diff in aws-elixir and aws-erlang to a bare minimum.
    
    Some minor diffs were unavoidable and deemed acceptable
    * Fix SuccessStatusCode to always be 200 if not provided by AWS in the API
      * Before SuccessStatusCode was set to undefined/nil. This was unhandled and would've caused errors.
    * Fix aws-erlang/issues/148 to allow send_body_as_binary & receive_body_as_binary to be sent in as options
      * The default remains the same, but certain APIs may require a change of the default depending on the in- or output
    * Drop abbreviation from metadata. It is no longer available in aws-sdk-go-v2 and unused in aws-elixir
    * Slight formatting changes on aws-erlang docs as the new docs contain a lot more newlines and hence cause more noise
    * Uri Paths may have changed. This should not impact the clients. It was likely broken in the aws-sdk-go
    * QueryMap may have changed but should not impact the client. It was likely broken in the aws-sdk-go
    * Docs have changed (massively) since almost all documentation has been updated
    
    Co-authored-by: Amin Arria <[email protected]>
    Co-authored-by: Gustavo Mora González <[email protected]>
    Co-authored-by: Philip Sampaio <[email protected]>
    4 people committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    81947e6 View commit details
    Browse the repository at this point in the history