Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for the ec2 protocol #100

Merged

Conversation

cheese-head
Copy link
Contributor

These changes would add support for the ec2 protocol.

@onno-vos-dev
Copy link
Member

Will review later during the day but letting pipelines run in the meantime 👌 Thank you for the PR's already! <3

@onno-vos-dev
Copy link
Member

Sorry for the delay, I've pushed a small fix which avoids a compilation warning on Erlang 👌

Will wait for codegen to pass and then merge this branch. I noticed your aws-elixir branch generating a compilation warning due to inspector_scan not having any actual operations to be used. So I have a fix lined up for that which should take care of that 👌

@onno-vos-dev onno-vos-dev merged commit c6aec7c into aws-beam:master Dec 15, 2023
3 checks passed
@onno-vos-dev
Copy link
Member

And thank you @cheese-head <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants