upgrade version of amplify to v5 #449
Conversation
katiegoines
changed the title
|
Not sure if this staging site is up to date https://amplify-upgrade.dm6i4p3zktlna.amplifyapp.com/ but it looks like we might be losing some styling or theming with the upgrade |
|
No courses found!! |
katiegoines
force-pushed
the
amplify-upgrade
branch
from
2e52f44
to
83d2404
Compare
| @@ -79,7 +79,7 @@ export function CardLayout({ | |||
| borderRadius="8px" | |||
| padding="0px 0px 0px 0px" | |||
| overflow="hidden" | |||
| src={course?.image} | |||
| src={course?.image.substring(6)} | |||
There was a problem hiding this comment.
Is the src we need always going to be at image.substring(6)? Did the upgrade do something to the strings?
| for (const contributorCourse of contributorCourses) { | ||
| const id = await contributorCourse.id; | ||
| const contributor = await contributorCourse.contributor; | ||
|
|
||
| const course = await contributorCourse.course; | ||
| resolvedCourses.push({id, contributor:contributor, course: course}); | ||
| } |
There was a problem hiding this comment.
I'm a little confused by this loop, why do we have it? It looks like it's just accessing the properties from contributorCourses and just making a new object array to filter? Is there a reason we need to await the properties too?
There was a problem hiding this comment.
Was this updated by Amplify? Would you happen to know why it has the Eager and Lazy word in front of the type names?
Issue #, if available:
Stepping the learn site up to aws-amplify v5
staging: https://amplify-upgrade.dm6i4p3zktlna.amplifyapp.com/learn
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.