Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test handling, prepares for e2e runs #514

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

josefaidt
Copy link
Contributor

@josefaidt josefaidt commented Oct 15, 2023

Issue #, if available:

related #509

Description of changes:

This PR primarily aims to prepare the test handling for live environments where we would like to test general auth flows, etc.

  • skips webhook tests on live environments
  • skips webhook tests when env vars are not set
  • adds env var schema with zod to support a TEST_HOST variable
    • also ensures DISCORD_GUILD_ID is set, primarily for cookie testing
  • adds a default Playwright project to prepare for extension with auth testing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@josefaidt josefaidt requested a review from a team as a code owner October 15, 2023 18:51
@josefaidt josefaidt added the run-ci Label to trigger action run for CI label Oct 15, 2023
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Oct 15, 2023
@josefaidt josefaidt temporarily deployed to ci October 15, 2023 18:52 — with GitHub Actions Inactive
@josefaidt josefaidt added the run-ci Label to trigger action run for CI label Oct 15, 2023
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Oct 15, 2023
@josefaidt josefaidt merged commit f58bc67 into aws-amplify:main Nov 22, 2023
3 checks passed
@josefaidt josefaidt deleted the improve-frontend-tests branch November 22, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant