-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(MobileClient): Removing deprecated methods #5459
base: main
Are you sure you want to change the base?
Conversation
Note: The AWSLex integration is failing because in order to run in Xcode 15 (i.e. the default in Because of the |
OTHER_LDFLAGS = "-ObjC"; | ||
OTHER_LDFLAGS = ( | ||
"-ObjC", | ||
"-ld64", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for Xcode 15
, which is the default now in macos-13
Issue #, if available:
AWSMobileClient
when initialising at runtime. #5458Description of changes:
Removing the following methods from
AWSMobileClient
:interceptApplication(_:didFinishLaunchingWithOptions:)
interceptApplication(_:didFinishLaunchingWithOptions:resumeSessionWithCompletionHandler:)
setSignInProviders(_:)
getCredentialsProvider()
These were meant to be removed way back in
2.11.0
, but since they still exists in the Objective-C interface they were still accessible.Check points:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.