feat: use url encoding type for list calls #14010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavosu
requested review from
haverchuck,
cshfang,
HuiSF and
a team
as code owners
packages/storage/src/providers/s3/utils/client/s3data/listObjectsV2.ts
Outdated
Show resolved
Hide resolved
ashika112
reviewed
Nov 13, 2024
packages/storage/__tests__/providers/s3/apis/internal/list.test.ts
Outdated
Show resolved
Hide resolved
| const decodeEncodedElements = ( | ||
| listOutput: ListObjectsV2Output, | ||
| ): ListObjectsV2Output => { | ||
| if (listOutput.EncodingType !== 'url') { |
There was a problem hiding this comment.
Can this be not url if we are the ones setting this in first place?
There was a problem hiding this comment.
I think it's highly unlikely, but I'd rather be safe.
pranavosu
changed the title
HuiSF
approved these changes
Nov 14, 2024
ashika112
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
urlfor list requests.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.