Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(adapter-nextjs): support next.js 15 #13947

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(adapter-nextjs): support next.js 15 #13947

wants to merge 6 commits into from
+68 −54

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Oct 22, 2024

Description of changes

  • Adapt the next.js breaking change (cookies from next/headers is now async [reference])

Issue #, if available

#13924

Description of how you validated changes

  1. npx next build
  2. unit tests
  3. automated e2e tests with a sample app that uses Next.js v15
  4. automated e2e tests with a smaple app that uses Next.js v14 (backwards compatibility)
  5. manual testing

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AllanZhengYP
AllanZhengYP reviewed Oct 23, 2024
View reviewed changes
packages/adapter-nextjs/src/utils/createCookieStorageAdapterFromNextServerContext.ts
): CookieStorage.Adapter => {
const cookieStore = cookies();
): Promise<CookieStorage.Adapter> => {
const cookieStore = await cookies();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😔

@HuiSF HuiSF marked this pull request as ready for review October 23, 2024 18:23
@HuiSF HuiSF requested review from haverchuck, cshfang and a team as code owners October 23, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjarvisp jjarvisp jjarvisp approved these changes

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

@haverchuck haverchuck Awaiting requested review from haverchuck haverchuck is a code owner

@cshfang cshfang Awaiting requested review from cshfang cshfang is a code owner

@pranavosu pranavosu Awaiting requested review from pranavosu pranavosu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuiSF @AllanZhengYP @jjarvisp