Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): associateWebAuthnCredential API #13875

Open
wants to merge 4 commits into
base: feat/passwordless
Choose a base branch
from

Conversation

jjarvisp
Copy link
Member

@jjarvisp jjarvisp commented Oct 2, 2024

Description of changes

The purpose of this pull request is to add a new external associateWebAuthnCredential API to allow users to register new passkeys.

Issue #, if available

Description of how you validated changes

  • manual testing in sample app
  • unit tests

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jjarvisp jjarvisp force-pushed the feat/create-passkey branch 2 times, most recently from 7587e9c to be296d5 Compare October 2, 2024 15:54
@jjarvisp jjarvisp changed the title feat(auth): create associateWebAuthnCredential API feat(auth): associateWebAuthnCredential API Oct 2, 2024
@jjarvisp jjarvisp marked this pull request as ready for review October 2, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant