Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Amplify JS release #13690

Merged
merged 6 commits into from
Aug 7, 2024
Merged

release: Amplify JS release #13690

merged 6 commits into from
Aug 7, 2024

Conversation

yuhengshs
Copy link
Contributor

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ashika112 and others added 4 commits August 6, 2024 09:54
…n getUrl (#13615)

* added content disposition and content type for getUrl and corresponded unit tests

* Update content disposition type for getUrl and uploadData, increase bundle size for both

* Update package.json to bump up bundle size

* extracted content disposition as interface and constructContentDisposition to util

* export Content Disposition interface

* Update  path to relative path. Update description for contentDisposition in options

* update descriptions for contentDisposition

* update LoadOrCreateMultipartUploadOptions's contentDisposition

* add full coverage unit test for

* Bump up getUrl package size to 15.63KB

Bump up getUrl package size to 15.63KB

* Bump up getUrl package size to 15.64KB

the size exceeded 1B
… field (#13669)

* chore(core): fix JsonObject type doesn't allow array of JsonObject as field

* chore: fix an array of types

* chore: allow array of JsonArray

* chore: refine the test
HuiSF
HuiSF previously approved these changes Aug 7, 2024
@yuhengshs yuhengshs marked this pull request as ready for review August 7, 2024 21:32
ashika112
ashika112 previously approved these changes Aug 7, 2024
jimblanc
jimblanc previously approved these changes Aug 7, 2024
david-mcafee
david-mcafee previously approved these changes Aug 7, 2024
@HuiSF HuiSF dismissed stale reviews from david-mcafee, jimblanc, ashika112, and themself via 43ceb84 August 7, 2024 22:11
@yuhengshs yuhengshs merged commit 9b2df98 into release Aug 7, 2024
245 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants