-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: Amplify JS release #13690
Merged
release: Amplify JS release #13690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n getUrl (#13615) * added content disposition and content type for getUrl and corresponded unit tests * Update content disposition type for getUrl and uploadData, increase bundle size for both * Update package.json to bump up bundle size * extracted content disposition as interface and constructContentDisposition to util * export Content Disposition interface * Update path to relative path. Update description for contentDisposition in options * update descriptions for contentDisposition * update LoadOrCreateMultipartUploadOptions's contentDisposition * add full coverage unit test for * Bump up getUrl package size to 15.63KB Bump up getUrl package size to 15.63KB * Bump up getUrl package size to 15.64KB the size exceeded 1B
… field (#13669) * chore(core): fix JsonObject type doesn't allow array of JsonObject as field * chore: fix an array of types * chore: allow array of JsonArray * chore: refine the test
HuiSF
previously approved these changes
Aug 7, 2024
ashika112
approved these changes
Aug 7, 2024
yuhengshs
requested review from
ukhan-amazon,
haverchuck,
cshfang,
jimblanc and
a team
as code owners
August 7, 2024 21:32
ashika112
previously approved these changes
Aug 7, 2024
jimblanc
previously approved these changes
Aug 7, 2024
david-mcafee
previously approved these changes
Aug 7, 2024
HuiSF
dismissed stale reviews from david-mcafee, jimblanc, ashika112, and themself
via
August 7, 2024 22:11
43ceb84
ashika112
approved these changes
Aug 7, 2024
jimblanc
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.