chore(auth): update auth plugin impl and config state machine to use AuthOutputs instead of Auth config #5456
+48
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikaHsn
force-pushed
the
chore/auth-plugin-and-config-state-machine
branch
2 times, most recently
from
7072cba
to
aa54b99
Compare
…AuthOutputs instead of Auth config
NikaHsn
force-pushed
the
chore/auth-plugin-and-config-state-machine
branch
from
aa54b99
to
a190fe5
Compare
Equartey
reviewed
Sep 17, 2024
| if (clientSecret != null) { | ||
| b.secretHash = computeSecretHash( | ||
| username, | ||
| _userPoolConfig.appClientId, | ||
| _authOutputs.userPoolClientId!, |
There was a problem hiding this comment.
Q: do we need a proper null check before force unwrapping _authOutputs.userPoolClientId!?
There was a problem hiding this comment.
we have a check when we get the _authOutputs from the dependency manager. it is line128
Equartey
approved these changes
Sep 17, 2024
khatruong2009
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.