Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(auth): add email otp mfa enums and types #5237
chore(auth): add email otp mfa enums and types #5237
Changes from all commits
1b5d2bd
a6492d7
755f30d
95f658b
1f72aca
a5abb1e
edaf999
630adad
3f4efce
438f800
b4a8ceb
d7f3d5d
c98ce74
c1d33e3
18a5316
d484c55
f604447
b0c03b7
5153683
1d37cae
e69d96b
764f16d
26becec
86a3228
13e60c4
0d725dc
69abe75
970bf15
5586c16
4725074
f0b69a3
7b901af
66097f2
0fdcc15
e630a30
334e8b3
87bb72b
c4ee27d
dd76942
d602bef
e98a31c
d7ebd26
aad9883
9d9abe8
e7e0888
4135f06
eb93be4
daacad7
a3c57e9
7129360
865d204
2fddb4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: is
signInRes.nextStep.totpSetupDetails
not null forsignInRes.nextStep.signInStep
==continueSignInWithMfaSetupSelection
?based on reading the code I think
signInRes.nextStep.totpSetupDetails
is present whensignInRes.nextStep.signInStep
iscontinueSignInWithTotpSetup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct,
signInRes.nextStep.totpSetupDetails
is not nullThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean signInRes.nextStep.totpSetupDetails is not null for
continueSignInWithMfaSetupSelection
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
answered here