chore(api)!: Model .fromJson() Refactor #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equartey
force-pushed
the
chore/api-from-json-refactor
branch
2 times, most recently
from
76e8dbf
to
77909a9
Compare
Equartey
changed the title
Equartey
force-pushed
the
chore/api-from-json-refactor
branch
from
5981c2c
to
2e5e0e3
Compare
Equartey
force-pushed
the
chore/api-from-json-refactor
branch
from
dbbb859
to
810685b
Compare
Jordan-Nelson
previously approved these changes
Apr 19, 2024
| @@ -44,5 +44,15 @@ end | |||
| post_install do |installer| | |||
| installer.pods_project.targets.each do |target| | |||
| flutter_additional_ios_build_settings(target) | |||
| target.build_configurations.each do |config| | |||
| # Workaround for: https://github.com/flutter/flutter/issues/126449 | |||
There was a problem hiding this comment.
Q: Is this still needed? The GH issue linked says it was resolved in flutter v3.10
There was a problem hiding this comment.
Good catch, no it should be removed.
packages/amplify_datastore/test/resources/observe_api/blog_type_success_event.json
Show resolved
Hide resolved
NikaHsn
previously approved these changes
Apr 19, 2024
This was referenced Apr 22, 2024
Jordan-Nelson
approved these changes
Apr 23, 2024
NikaHsn
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#816
Description of changes:
Flattens the nested data structure of
serializedDataacross the method channel and the.fromJson()method found on codegen models. This PR is to be paired with changes in aws-amplify/amplify-codegen#593By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.