chore(aft): Package aft should not have pubspec_overrides.yaml
#3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike every other package, aft must work without `pubspec_overrides`. It's counter productive to generate it and and its presence can interfere with local development.
Equartey
reviewed
Sep 12, 2023
| // It's counter productive to generate it and its presence can interfere | ||
| // with local development. | ||
| if (package.name == 'aft') { | ||
| await _removePubspecOverride(package); |
There was a problem hiding this comment.
Could we prevent the override file from being created in the first place?
There was a problem hiding this comment.
Whoops. Should've been a return. Fixed 👍
Jordan-Nelson
previously approved these changes
Sep 12, 2023
Jordan-Nelson
approved these changes
Sep 12, 2023
Equartey
approved these changes
Sep 12, 2023
fjnoyp
pushed a commit
that referenced
this pull request
Sep 21, 2023
…3733) * chore(aft): Package `aft` should not have `pubspec_overrides.yaml` Unlike every other package, aft must work without `pubspec_overrides`. It's counter productive to generate it and and its presence can interfere with local development. * return
fjnoyp
pushed a commit
that referenced
this pull request
Sep 21, 2023
…3733) * chore(aft): Package `aft` should not have `pubspec_overrides.yaml` Unlike every other package, aft must work without `pubspec_overrides`. It's counter productive to generate it and and its presence can interfere with local development. * return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike every other package, aft must work without
pubspec_overrides. It's counter productive to generate it and and its presence can interfere with local development.