Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(version): Bump version #3725

Merged
merged 31 commits into from
Sep 11, 2023
Merged

chore(version): Bump version #3725

merged 31 commits into from
Sep 11, 2023

Conversation

dnys1
Copy link
Contributor

@dnys1 dnys1 commented Sep 11, 2023

Fixes

  • fix(auth): Crash with EXC_BAD_ACCESS (#3657)
  • fix(auth): Custom auth with device tracking, no SRP (#3652)
  • fix(auth): Uncaught Hosted UI cancellation (#3686)
  • fix: removed trailing slash at the end of uri (#3626)

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee

dnys1 and others added 30 commits September 11, 2023 08:42
Basically, force a refresh. Some composite actions are failing due to stale credentials.

https://github.com/aws-actions/configure-aws-credentials#unset-current-credentials
Adds some more e2e tests for the `updateMfaPreference` API
chore(deps): Bump sqlite3

Bumps SQLite to 3.43.0

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@c85c95e...f43a0e5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…dcc4d0ba8eada7c08092aad5314 (#3603)

Updates the requirements on [dart-lang/setup-dart](https://github.com/dart-lang/setup-dart) to permit the latest version.
- [Release notes](https://github.com/dart-lang/setup-dart/releases)
- [Changelog](https://github.com/dart-lang/setup-dart/blob/main/CHANGELOG.md)
- [Commits](https://github.com/dart-lang/setup-dart/commits/e58aeb62aef51dcc4d0ba8eada7c08092aad5314)

---
updated-dependencies:
- dependency-name: dart-lang/setup-dart
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ckages/notifications/push/amplify_push_notifications/android (#3604)

chore(deps): Bump org.mockito:mockito-core

Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.4.0 to 5.5.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v5.4.0...v5.5.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ckages/amplify_datastore/android (#3602)

chore(deps): Bump org.mockito:mockito-core

Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.4.0 to 5.5.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v5.4.0...v5.5.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
feat(actions): Launch Android emulator
- Adds E2E workflows to `aft generate workflows`
- Removes mono-workflow for E2E tests
- Splits E2E workflows such that they run only when necessary
- Adds concurrency settings to all workflows
Adds tests which encode the behavior around `resendUserAttributeConfirmationCode` with and without the `keepOriginal` properties enabled in Cognito.
* removed trailing slash at the end of gql uri

* fix improved

* chore: refactor getUri

* chore: update test to include trailing slash

---------

Co-authored-by: Jordan Nelson <[email protected]>
* chore(deps): Bump process from 4.2.4 to 5.0.0 in /actions

Bumps [process](https://github.com/google/process.dart) from 4.2.4 to 5.0.0.
- [Release notes](https://github.com/google/process.dart/releases)
- [Changelog](https://github.com/google/process.dart/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/process.dart/commits)

---
updated-dependencies:
- dependency-name: process
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(actions): Update process manager interface

For conformance to `package:process` v5.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dillon Nys <[email protected]>
…dcc4d0ba8eada7c08092aad5314 (#3665)

Updates the requirements on [dart-lang/setup-dart](https://github.com/dart-lang/setup-dart) to permit the latest version.
- [Release notes](https://github.com/dart-lang/setup-dart/releases)
- [Changelog](https://github.com/dart-lang/setup-dart/blob/main/CHANGELOG.md)
- [Commits](https://github.com/dart-lang/setup-dart/commits/e58aeb62aef51dcc4d0ba8eada7c08092aad5314)

---
updated-dependencies:
- dependency-name: dart-lang/setup-dart
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Currently, `aft generate workflows` checks for the presence of a `workflow.yaml` file next to a `pubspec.yaml` to know if we should generate a GitHub action workflow or copy over the custom one. This leads to drift, though, since dependabot does not search these directories by default.

We could update Dependabot to search these directories, but instead we add a setting to the aft config to say that the workflow which exists is custom and should not be overridden so that the information is not copied in two places.
The fix in #3558 assumed that device SRP would only be performed when password SRP had previously been performed as part of a custom Auth workflow. However, this is not true. In custom auth workflows without password SRP, device SRP can still be required when device tracking is enabled, and in this case it is not a requirement that password SRP have been previously performed.
fix(auth): Crash with `EXC_BAD_ACCESS`

Adds checks to results of `IOServiceGetMatchingService` and `IORegistryEntryCreateCFProperty` FFI calls to prevent trying to access bad data in cast or free calls.
* chore(auth): Use `EventCompleter.ignore` instead of `unawaited`

`unawaited` will still raise an error if there is one. By using `EventCompleter.ignore` we drop all completions, success or error.

* fix(auth): Uncaught Hosted UI cancellation

The HostedUIPlatform had a bug due to the fact that it both called `dispatcher.dispatchAndComplete` (which throws on failure states) and throwing a `UserCancelledException` which triggers a failure state. This lead to the error being thrown from `signInWithWebUI` and an uncaught exception being raised at the `dispatchAndComplete` call.

This resolves the issue by only throwing from the HostedUiPlatform and letting the state machine resolving the cancellation.

This also fixes an issue where `cancelSignIn` was never being called because the state machine was in a `signingIn` state at the time the cancellation was dispatched.
Force unwrapping nullable values is done in JS by calling `nullableValue.toString` which will throw an error if `nullableValue` is null. Browsers seem to handle this sort of error different than a thrown Dart error and the error is harder to trace when it happens.

Introduces an `unwrapParameter` method to the base worker bee class so that unwrap errors are strongly-typed and provide more context to the issue.
Running heavy computations on the main thread in Web tests causes flaky behavior. Even on high performance computers, the interplay of the Dart runner, DDC, and browser engine causes frequent timeouts when blocking the main thread.

Since these operations are tested elsewhere for Web in places where they are offloaded, skip them for Web.
Fixes flaky HostedUI test by updating expectations and not relying on the timings of the event loop.
ci(auth): Prevent eventual consistency issues
### Fixes
- fix(auth): Crash with EXC_BAD_ACCESS ([#3657](#3657))
- fix(auth): Custom auth with device tracking, no SRP ([#3652](#3652))
- fix(auth): Uncaught Hosted UI cancellation ([#3686](#3686))
- fix: removed trailing slash at the end of uri ([#3626](#3626))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@dnys1 dnys1 marked this pull request as ready for review September 11, 2023 16:25
@dnys1 dnys1 requested a review from a team as a code owner September 11, 2023 16:25
@dnys1 dnys1 merged commit ca5f111 into stable Sep 11, 2023
162 of 164 checks passed
@dnys1 dnys1 deleted the chore/release/mid-sept branch September 11, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants