refactor(ci): Allow region split #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See last "fixes" commit for passing workflows |
Equartey
previously approved these changes
Sep 8, 2023
For testing eventual consistency issues.
Equartey
approved these changes
Sep 12, 2023
Jordan-Nelson
approved these changes
Sep 25, 2023
Equartey
pushed a commit
that referenced
this pull request
Oct 26, 2023
* refactor(ci): Allow region split * ci(auth): Use `eu-south-1` For testing eventual consistency issues. * trigger ci * test * test * revert eu-south-1 * Remove test
Equartey
pushed a commit
that referenced
this pull request
Oct 30, 2023
* refactor(ci): Allow region split * ci(auth): Use `eu-south-1` For testing eventual consistency issues. * trigger ci * test * test * revert eu-south-1 * Remove test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the E2E stack to allow splitting the stacks between regions. Some features are not available in
eu-south-1so we will be splitting the categories betweenus-west-2(analytics, storage) andeu-south-1(auth).In particular this makes each category's stack a true
Stackinstead of aNestedStackso they can have their own region.Before: Root (
Stack) -> Category (NestedStack) -> Category Environment (NestedStack)After: Root (
Stack) -> Category (Stack) -> Category Environment (NestedStack)This also migrates a lot of the configuration management to the backend. A
Triggerruns after every deployment to upload the consolidatedamplifyconfiguration.dartfile. The local Dart file simply downloads the file instead of uploading it.This also moves the GitHub OIDC and secrets management to CDK so that manual management of the secrets is no longer needed - they are updated automatically after each deployment. To protect Amplify app IDs, a custom resource pulls app IDs on deployment using hard-coded app names (which are not secret).
Overall, this provides cleaner separation of resources and improves deployment speed by a few minutes on average. It also means categories can be deployed independently again and rollbacks happen per category, not for the whole backend.