chore(aft): Custom GitHub actions config #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
previously approved these changes
Aug 29, 2023
Equartey
previously approved these changes
Aug 29, 2023
Currently, `aft generate workflows` checks for the presence of a `workflow.yaml` file next to a `pubspec.yaml` to know if we should generate a GitHub action workflow or copy over the custom one. This leads to drift, though, since dependabot does not search these directories by default. We could update Dependabot to search these directories, but instead we add a setting to the aft config to say that the workflow which exists is custom and should not be overridden so that the information is not copied in two places.
dnys1
force-pushed
the
chore/aft/custom-gh-actions
branch
from
dd14501
to
8672967
Compare
Jordan-Nelson
approved these changes
Aug 31, 2023
Equartey
approved these changes
Aug 31, 2023
dnys1
added a commit
that referenced
this pull request
Sep 11, 2023
Currently, `aft generate workflows` checks for the presence of a `workflow.yaml` file next to a `pubspec.yaml` to know if we should generate a GitHub action workflow or copy over the custom one. This leads to drift, though, since dependabot does not search these directories by default. We could update Dependabot to search these directories, but instead we add a setting to the aft config to say that the workflow which exists is custom and should not be overridden so that the information is not copied in two places.
dnys1
added a commit
that referenced
this pull request
Sep 11, 2023
Currently, `aft generate workflows` checks for the presence of a `workflow.yaml` file next to a `pubspec.yaml` to know if we should generate a GitHub action workflow or copy over the custom one. This leads to drift, though, since dependabot does not search these directories by default. We could update Dependabot to search these directories, but instead we add a setting to the aft config to say that the workflow which exists is custom and should not be overridden so that the information is not copied in two places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
aft generate workflowschecks for the presence of aworkflow.yamlfile next to apubspec.yamlto know if we should generate a GitHub action workflow or copy over the custom one. This leads to drift, though, since dependabot does not search these directories by default.We could update Dependabot to search these directories, but instead we add a setting to the aft config to say that the workflow which exists is custom and should not be overridden so that the information is not copied in two places.