chore(aft): Better handling of pre-release Dart SDK usage #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
force-pushed
the
chore/aft/preview-constraints
branch
from
57f7e09
to
07b244e
Compare
Equartey
previously approved these changes
Aug 17, 2023
fjnoyp
reviewed
Aug 17, 2023
| // The problem of packages setting incorrect constraints, for example setting | ||
| // `^3.0.5` when the current repo constraint is `^3.0.0` and we're running | ||
| // `aft` with `3.0.1` is a different issue handled by the constraints commands. | ||
| (pkg) => pkg.compatibleWithCurrentSdk, |
There was a problem hiding this comment.
Should we print the packages that are ignored as a result? In the future should someone change to a incompatible Dart SDK for whatever reason, perhaps it would be good to notify it's being ignored in bootstrap should some confusion result.
fjnoyp
reviewed
Aug 17, 2023
| @override | ||
| List<Object?> get props => [name]; | ||
|
|
||
| @override | ||
| String get runtimeTypeName => 'PackageInfo'; |
There was a problem hiding this comment.
General programming approach question - why do we combine multiple classes into the same file? As someone unfamiliar with your aft code it's a bit confusing to have these large files to scroll through and also not being able to search by classes by file name that match the class contained.
fjnoyp
previously approved these changes
Aug 18, 2023
dnys1
force-pushed
the
chore/aft/preview-constraints
branch
4 times, most recently
from
9cf0524
to
32db8b8
Compare
dnys1
force-pushed
the
fix/aft/publish-constraints
branch
2 times, most recently
from
206b2fb
to
50b8e21
Compare
dnys1
dismissed stale reviews from fjnoyp and Equartey
The base branch was changed.
Some packages in the repo (for example, the `actions` pkg) set a pre-release Dart SDK constraint so that preview features of Dart can be leveraged. This updates `aft` so that: 1) `bootstrap` skips packages which set this constraint if the current Dart SDK doesn't support it; and 2) Ignores preview constraints in the constraints checker, since these packages do not need to conform to the global setting.
dnys1
force-pushed
the
chore/aft/preview-constraints
branch
from
32db8b8
to
4ecc37e
Compare
Equartey
approved these changes
Aug 25, 2023
fjnoyp
approved these changes
Aug 25, 2023
dnys1
added a commit
that referenced
this pull request
Aug 28, 2023
Some packages in the repo (for example, the `actions` pkg) set a pre-release Dart SDK constraint so that preview features of Dart can be leveraged. This updates `aft` so that: 1) `bootstrap` skips packages which set this constraint if the current Dart SDK doesn't support it; and 2) Ignores preview constraints in the constraints checker, since these packages do not need to conform to the global setting.
dnys1
added a commit
that referenced
this pull request
Aug 30, 2023
Some packages in the repo (for example, the `actions` pkg) set a pre-release Dart SDK constraint so that preview features of Dart can be leveraged. This updates `aft` so that: 1) `bootstrap` skips packages which set this constraint if the current Dart SDK doesn't support it; and 2) Ignores preview constraints in the constraints checker, since these packages do not need to conform to the global setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages in the repo (for example, the
actionspkg) set a pre-release Dart SDK constraint so that preview features of Dart can be leveraged. This updatesaftso that:bootstrapskips packages which set this constraint if the current Dart SDK doesn't support it.