chore: Global Metric Tracking #3535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
reviewed
Aug 9, 2023
fjnoyp
force-pushed
the
feat/globalMetrics
branch
from
7e551f1
to
38fdb15
Compare
fjnoyp
changed the title
|
The tests will fail because it requires secrets such as AWS Region and Github Token to be set. We have an internal AppSec Consultation open to validate the creation of the Github Token. In the meantime, it would be good to get team reviews for this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Track the fields of global metrics that we discussed.
Add code to track the failing step. Identifying the failing job was a bit tricky, so we send all the matrix values comma delimited to parse the jobs json response from github to get the job id for getting the failing step in another step.
Please Note
I am unable to test on this repo because the github secrets needs to be updated with a Github Token for making the requests to Github API for which step has failed on the job.
Thus this PR cannot be pushed as is. Furthermore you'll see that the repo URL in the requests are pointing to my github repo (fnoyp/amplify-flutter) instead of (aws-amplifiy/amplify-flutter).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.