chore(smithy): Service clients prep #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 8, 2023 11:20
Updates Smithy version when `--update` is passed to the `generate goldens` command.
…t `httpPayload` Don't consider metadata members when a service does not support the `httpPayload` trait. Some Smithy models may include these traits but they should just be ignored.
In order to clean up generated code a bit, only prefix types exported from the runtime packages (e.g. `aws_common`, `smithy`). This can probably be refined further to use `show` instead but this would require dynamically updating the types which conflict or enumerating them all up front.
To remove import prefixes.
dnys1
force-pushed
the
feat/amplify-service-clients
branch
from
2e8088c
to
384471b
Compare
dnys1
commented
Aug 8, 2023
| @@ -0,0 +1,57 @@ | |||
| import 'dart:async'; | |||
There was a problem hiding this comment.
License headers added in subsequent commit
dnys1
added
pr:rebase
Jordan-Nelson
previously approved these changes
Aug 9, 2023
| }); | ||
|
|
||
| final bool withPrefixing; | ||
| final PrefixStrategy withPrefixing; |
There was a problem hiding this comment.
nit: Might make sense to rename this withPrefixStrategy
Jordan-Nelson
approved these changes
Aug 14, 2023
Equartey
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aftto correctly pull latest Smithy version (commit)_i0.- commit)