chore(smithy): Codegen improvements #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 19, 2023 12:37
- Adds further override capabilities for shapes - Aligns `@default` and `@required` behavior more closely to the spec - Only generates `_init` if necessary
Since this tests very specific V2 features, the V1 transformation doesn't provide any value and prevents certain usages.
Equartey
approved these changes
Jul 20, 2023
NikaHsn
reviewed
Jul 20, 2023
| @@ -1033,20 +1033,6 @@ updates: | |||
| - dependency-name: "amplify_lints" | |||
| - dependency-name: "smithy_aws" | |||
| - dependency-name: "aws_signature_v4" | |||
| - package-ecosystem: "pub" | |||
| directory: "packages/smithy/goldens/lib/custom" | |||
There was a problem hiding this comment.
Q: why removing the packages/smithy/goldens/lib/custom and not others in packages/smithy/goldens/lib e.g. packages/smithy/goldens/lib/awsQuery or packages/smithy/goldens/lib/awsJson1_1 ?
There was a problem hiding this comment.
custom has smithy tests I wrote by hand. The v1 / v2 split is meant to track differences in Smithy IDL versions since the AWS-vended Smithy models were (in the past) not fully migrated to V2. I think they've all been migrated at this point, so we can probably remove all v1 soon.
However, for the handwritten tests, it's not necessary to test V1 since many of the tests are specifically testing V2 features.
NikaHsn
approved these changes
Jul 20, 2023
dnys1
added a commit
that referenced
this pull request
Jul 27, 2023
* chore(smithy): Codegen improvements - Adds further override capabilities for shapes - Aligns `@default` and `@required` behavior more closely to the spec - Only generates `_init` if necessary * chore(aft): Don't generate V1 models for `custom` service Since this tests very specific V2 features, the V1 transformation doesn't provide any value and prevents certain usages. * test(goldens): Add default value tests * fix(aft): SDK models are V2 * chore(repo): Regenerate SDK * chore(repo): Clean up
dnys1
added a commit
that referenced
this pull request
Jul 28, 2023
* chore(smithy): Codegen improvements - Adds further override capabilities for shapes - Aligns `@default` and `@required` behavior more closely to the spec - Only generates `_init` if necessary * chore(aft): Don't generate V1 models for `custom` service Since this tests very specific V2 features, the V1 transformation doesn't provide any value and prevents certain usages. * test(goldens): Add default value tests * fix(aft): SDK models are V2 * chore(repo): Regenerate SDK * chore(repo): Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@defaultand@requiredbehavior more closely to the spec_initif necessary