Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aft): Add generate goldens command #3299

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

dnys1
Copy link
Contributor

@dnys1 dnys1 commented Jun 22, 2023

Removes bespoke generation script for goldens and integrates it into aft.

@dnys1 dnys1 requested a review from a team as a code owner June 22, 2023 18:35
Jordan-Nelson
Jordan-Nelson previously approved these changes Jun 27, 2023
NikaHsn
NikaHsn previously approved these changes Jun 27, 2023
@dnys1 dnys1 force-pushed the chore/aft/generate-sdk-improvements branch from cb21488 to b48031e Compare June 28, 2023 18:21
Base automatically changed from chore/aft/generate-sdk-improvements to main June 28, 2023 19:25
@dnys1 dnys1 dismissed stale reviews from NikaHsn and Jordan-Nelson June 28, 2023 19:25

The base branch was changed.

Removes bespoke generation script for goldens and integrates it into `aft`.
@dnys1 dnys1 force-pushed the chore/aft/generate-goldens branch from 9650307 to e9d509b Compare June 28, 2023 19:27
@dnys1 dnys1 merged commit 1113d32 into main Jun 28, 2023
@dnys1 dnys1 deleted the chore/aft/generate-goldens branch June 28, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants