chore(storage): Unpin models ref #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
force-pushed
the
fix/storage/unpin-models-ref
branch
2 times, most recently
from
4759f97
to
8502ae8
Compare
Jordan-Nelson
previously approved these changes
Jun 27, 2023
NikaHsn
previously approved these changes
Jun 27, 2023
dnys1
force-pushed
the
chore/smoke-test/skip-failing-api-gateway
branch
from
96b6d6b
to
5c38893
Compare
Base automatically changed from
chore/smoke-test/skip-failing-api-gateway
to
main
June 28, 2023 17:30
dnys1
dismissed stale reviews from NikaHsn and Jordan-Nelson
The base branch was changed.
added 4 commits
June 28, 2023 10:31
S3 incorrectly sets primitive values as boxed which causes errors when interacting with the service. Until this is fixed, we explicitly unbox them.
Newer smithy models seem to have resolved the issues around improper default values.
Newer smithy models seem to have resolved the issues around improper default values.
dnys1
force-pushed
the
fix/storage/unpin-models-ref
branch
from
8502ae8
to
bf052eb
Compare
Jordan-Nelson
approved these changes
Jun 28, 2023
NikaHsn
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpins Smithy models to take the latest.
S3 seems to still be struggling with default values (due to the fact that the old Coral models incorrectly used certain traits). In the meantime, SDKs are working around this by simply ignoring the default values for booleans and numbers and making them nullable.