-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aft): Docs commands #2965
feat(aft): Docs commands #2965
Conversation
# | ||
# TODO(dnys1): Create mapping of Flutter->Dart versions so we can just use Dart | ||
# vended by Flutter. | ||
- name: Setup Flutter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed for publishing the built docs with workflow at some point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Even though amplify_core
is Dart-only, the examples we showcase in its docs all reference Flutter packages. So the doc
package in amplify_core
needs a dependency on Flutter so that we can have Flutter-specific samples in the amplify_core
docs.
Would the next step be to automatically call your aft build docs command to generate docs for each release? Is it possible for users navigating our Github to see the index.html of that package's doc output in the current package folder? So if they're navigating our code and want to see docs for It seems right now we consolidate all docs in the output dir. |
I appear to be running the command wrong? I was able to run
Which then hangs indefinitely. Looking at the code I'm not 100% sure why amplified_todo keeps getting selected as well. Regardless it seems I cannot run the build command for all of amplify? I've run aft clean and bootstrap. I see that the docs files are generated for aft/amplified_todo/infra. |
You mean to verify before publishing? Maybe. I think a next step could be to build docs for PRs and publish them to a temporary domain similar to the docs repo so that changes are more visible.
What would be the benefit of this over visiting the published docs on
You are running the command correctly. I've pushed some updates to make the error output more clear. Running
|
doc/api/ | ||
**/doc/api/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these not exclude the same dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No one is the top-level doc dir, the other applies to all sub-packages
@@ -5,4 +5,3 @@ analyzer: | |||
public_member_api_docs: ignore | |||
exclude: | |||
- lib/**/*.g.dart | |||
- doc/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you verify we don't lose any pub points from analysis by changing this? Looks like we're currently 130/140, but lets avoid a regression if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal is ultimately to not require any excludes which will help us catch analysis errors in CI which may show up in pub. Removing this exclude will help make sure our pub points remain high 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification there, I scoped the docs serve command to get a reasonable subset to run docs against. Looking good so approved.
bf72791
to
8d51e37
Compare
No longer needed since we don't embed `pub`
Adds `aft docs build` and `aft docs serve` to compile docs and serve docs on a local HTTP server with auto-rebuild, respectively.
Some Dart packages require Flutter to be available, for example `amplify_core` requires it for its `doc` package.
Adds
aft docs build
andaft docs serve
to compile docs and serve docs on a local HTTP server with auto-rebuild, respectively.