Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): TOTP MFA #1770

Closed
wants to merge 4 commits into from
Closed

feat(auth): TOTP MFA #1770

wants to merge 4 commits into from

Conversation

dnys1
Copy link
Contributor

@dnys1 dnys1 commented Jun 18, 2022

Introduces TOTP MFA with registration and verification flows. There are no new APIs for this approach. Instead, confirmSignIn is leveraged with two new sign in step types: mfaSetup and confirmSignInWithTotpMfaCode.


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

Dillon Nys added 4 commits June 18, 2022 11:25
Adds support for the `USER_PASSWORD_AUTH` flow

commit-id:993bd927
Small fixes around attribute handing

commit-id:d418754d
All error types should be handled by the state machine. If `resolveError` cannot handle it, add it to the state stream.

commit-id:59c9c765
Introduces TOTP MFA with registration and verification flows. There are no new APIs for this approach. Instead, confirmSignIn is leveraged with two new sign in step types: `mfaSetup` and `confirmSignInWithTotpMfaCode`.

commit-id:887d4a4d
@dnys1 dnys1 requested a review from a team as a code owner June 18, 2022 21:40
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2022

Codecov Report

Merging #1770 (1fd97f8) into pr/dnys1/missing-flows/59c9c765 (e470a7e) will not change coverage.
The diff coverage is n/a.

@@                       Coverage Diff                        @@
##           pr/dnys1/missing-flows/59c9c765    #1770   +/-   ##
================================================================
  Coverage                            44.49%   44.49%           
================================================================
  Files                                  121      121           
  Lines                                 7493     7493           
================================================================
  Hits                                  3334     3334           
  Misses                                4159     4159           
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 27.25% <ø> (ø)
ios-unit-tests 89.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dnys1 dnys1 marked this pull request as draft June 19, 2022 02:02
Base automatically changed from pr/dnys1/missing-flows/59c9c765 to next June 23, 2022 16:55
@schreyerpeter
Copy link

@dnys1 Thanks for tackling this! When do you estimate this feature will be released?

@dnys1
Copy link
Contributor Author

dnys1 commented Mar 2, 2023

@schreyerpeter no firm timelines at the moment unfortunately. We are looking to how best to release this and will add an update to the TOTP tracking ticket (#574) when we have a good estimate.

@schreyerpeter
Copy link

@schreyerpeter no firm timelines at the moment unfortunately. We are looking to how best to release this and will add an update to the TOTP tracking ticket (#574) when we have a good estimate.

Thank you very much! I'll keep an eye on that thread.

@bjernie
Copy link

bjernie commented Mar 14, 2023

Any news?

@abdallahshaban557 abdallahshaban557 added the auth Issues related to the Auth Category label Mar 16, 2023
@chrisdadej
Copy link

@dnys1 / @abdallahshaban557 Just checking to see if there's an update on getting this change merged and released?
Anything that we can help with to get it over the line? I'd like to avoid forking the code and maintaining a seperate instance just to get something as fundamental as 2FA in place for Flutter.

Note: There is one other API that's missing getPreferredMFA() in order to determine the user's current setting. Happy to help put that together if it can all be merged in together.

@abdallahshaban557
Copy link
Contributor

Hi @chrisdadej - we are getting really close to shipping this feature. We are just finalizing some interface changes to align our implementation to the other Amplify libraries. How soon do you need this?

@chrisdadej
Copy link

@abdallahshaban557 In development... yesterday :) In production we are targeting July 1 hence thinking of what a Plan B looks like if this functionality isn't ready.

If you need extra testers, or help in building out for example the getPreferredMFA() API please let me know. More than happy to help - it doesn't have to have perfect feature parity with the React library, but the auth / cognito / 2fa capabilities are a must.

@abdallahshaban557
Copy link
Contributor

Understood - thank you for pushing us to get this out sooner. We are trying our best to get it out ASAP, and we will keep your offer in mind to help us get this out sooner if possible. Thank you so much! Helping us test sounds amazing actually!

@dnys1
Copy link
Contributor Author

dnys1 commented Jun 5, 2023

Closing in favor of #3146

@dnys1 dnys1 closed this Jun 5, 2023
@Jordan-Nelson Jordan-Nelson deleted the pr/dnys1/missing-flows/887d4a4d branch October 20, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Issues related to the Auth Category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants