chore: remove flutter plugin files from git ignore now that flutter d…

…ependency is removed
aws-amplify · Sep 15, 2023 · 0ef2b3d · 0ef2b3d
1 parent 55dfab9
commit 0ef2b3d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/remote_constraint_provider.dart b/packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/remote_constraint_provider.dart
@@ -38,11 +38,25 @@ base class BaseRemoteLoggingConstraintProvider
     required DefaultRemoteConfiguration config,
     required AWSCredentialsProvider credentialsProvider,
     FileStorageImpl? fileStorage,
-    AWSHttpClient? awsHttpClient,
   })  : _fileStorage = fileStorage,
         _config = config,
         _credentialsProvider = credentialsProvider,
-        _awsHttpClient = awsHttpClient ?? AWSHttpClient() {
+        _awsHttpClient = AWSHttpClient() {
+    _init();
+  }
+
+  /// A [BaseRemoteLoggingConstraintProvider] to use only for testing.
+  @protected
+  @visibleForTesting
+  BaseRemoteLoggingConstraintProvider.forTesting({
+    required DefaultRemoteConfiguration config,
+    required AWSCredentialsProvider credentialsProvider,
+    required AWSHttpClient awsHttpClient,
+    FileStorageImpl? fileStorage,
+  })  : _fileStorage = fileStorage,
+        _config = config,
+        _credentialsProvider = credentialsProvider,
+        _awsHttpClient = awsHttpClient {
     _init();
   }
 
@@ -162,7 +176,6 @@ final class DefaultRemoteLoggingConstraintProvider
     required super.config,
     required this.credentialsProvider,
     super.fileStorage,
-    super.awsHttpClient,
   }) : super(credentialsProvider: credentialsProvider);
 
   /// The credentials provider to use for signing the request.

diff --git a/packages/logging_cloudwatch/aws_logging_cloudwatch/test/remote_constraint_provider_test.dart b/packages/logging_cloudwatch/aws_logging_cloudwatch/test/remote_constraint_provider_test.dart
@@ -118,7 +118,7 @@ void main() {
       when(() => mockFileStorage.loadConstraint(any()))
           .thenAnswer((_) async => Future.value(sampleJson));
 
-      provider = BaseRemoteLoggingConstraintProvider(
+      provider = BaseRemoteLoggingConstraintProvider.forTesting(
         config: const DefaultRemoteConfiguration(
           refreshInterval: Duration(seconds: 10),
           endpoint: 'https://example.com',