Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add build windows to workflows #659

Merged
merged 1 commit into from
Aug 3, 2023
Merged

chore: add build windows to workflows #659

merged 1 commit into from
Aug 3, 2023

Conversation

lawmicha
Copy link
Member

@lawmicha lawmicha commented Aug 3, 2023 •
edited
Loading

Description of changes

Add a section that was incorrectly removed in a previous PR: #630

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from a team as a code owner August 3, 2023 18:19
@dpilch dpilch merged commit 8e7d820 into main Aug 3, 2023
3 checks passed
@dpilch dpilch deleted the chore/build-windows branch August 3, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpilch dpilch dpilch approved these changes

@phani-srikar phani-srikar phani-srikar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lawmicha @dpilch @phani-srikar