Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codebuild e2e modelgen tests #633

Merged
merged 3 commits into from
Jul 17, 2023
Merged

fix: codebuild e2e modelgen tests #633

merged 3 commits into from
Jul 17, 2023

Conversation

phani-srikar
Copy link
Contributor

Description of changes

  • Add required additional Android dependencies to successfully build the Android modelgen test app
  • Add missing permissions to execute the script.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar requested review from a team as code owners July 16, 2023 04:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Merging #633 (ad37156) into main (225ad09) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files         152      152           
  Lines        7491     7491           
  Branches     1957     1957           
=======================================
  Hits         6437     6437           
  Misses        961      961           
  Partials       93       93           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phani-srikar phani-srikar changed the title fix: e2e android modelgen test fix: codebuild e2e android modelgen test Jul 16, 2023
@phani-srikar phani-srikar changed the title fix: codebuild e2e android modelgen test fix: codebuild e2e modelgen tests Jul 17, 2023
@phani-srikar phani-srikar merged commit c6d1152 into main Jul 17, 2023
@phani-srikar phani-srikar deleted the fix-e2e-cb branch July 29, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants