Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add scripts for ios-modelgen e2e test #629

Merged
merged 4 commits into from
Jul 14, 2023
Merged

chore: add scripts for ios-modelgen e2e test #629

merged 4 commits into from
Jul 14, 2023

Conversation

phani-srikar
Copy link
Contributor

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar requested a review from a team as a code owner July 14, 2023 00:35
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #629 (f3d2753) into main (ffd7cf7) will increase coverage by 1.49%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   84.44%   85.93%   +1.49%     
==========================================
  Files         152      152              
  Lines        6435     7489    +1054     
  Branches     1383     1956     +573     
==========================================
+ Hits         5434     6436    +1002     
- Misses        901      960      +59     
+ Partials      100       93       -7     

see 117 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AaronZyLee
AaronZyLee previously approved these changes Jul 14, 2023
@phani-srikar phani-srikar changed the title chore: make the ios-modelgen e2e test script executable chore: add scripts for ios-modelgen e2e test Jul 14, 2023
@phani-srikar phani-srikar merged commit 225ad09 into main Jul 14, 2023
@dpilch
Copy link
Member

dpilch commented Jul 14, 2023

What is the empty file .codebuild/scripts/run-ios-modelgen-e2e-test.sh?

@phani-srikar
Copy link
Contributor Author

What is the empty file .codebuild/scripts/run-ios-modelgen-e2e-test.sh?

That's updating the permissions on that script to be executable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants