-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add type branding to graphql in TS outputs #623
Merged
svidgen
merged 9 commits into
aws-amplify:main
from
svidgen:typecast-ts-graphql-option-2
Aug 23, 2023
Merged
feat: add type branding to graphql in TS outputs #623
svidgen
merged 9 commits into
aws-amplify:main
from
svidgen:typecast-ts-graphql-option-2
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
reviewed
Jul 13, 2023
packages/amplify-codegen/src/utils/GraphQLStatementsFormatter.js
Outdated
Show resolved
Hide resolved
alharris-at
previously approved these changes
Jul 14, 2023
packages/amplify-codegen/src/utils/GraphQLStatementsFormatter.js
Outdated
Show resolved
Hide resolved
svidgen
changed the title
wip: add types to graphql in TS outputs option 2
feat: add type branding to graphql in TS outputs
Aug 3, 2023
Marking as draft again until PM's can review next Thursday. Happy to incorporate feedback between now and then though. |
6 tasks
alharris-at
approved these changes
Aug 22, 2023
phani-srikar
approved these changes
Aug 22, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In order to brand the generated graphql for TypeScript, we need to know the underlying operation type (Query | Mutation | Subscription) and specific operation name (CreateBlog, ListBlogs, etc.) at the time the graphql is formatted for the language output. This PR:
statements
map.typescript
.Issue #, if available
Description of how you validated changes
arguments
andresult
Base cases
GraphQLQuery
andGraphQLSubscription
wrappers provides return typesChecklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.