chore: add cleanup resources script for codebuild #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronZyLee
commented
Jul 12, 2023
| @@ -8,5 +8,5 @@ if [ -z "$PR_NUM" ]; then | |||
| fi | |||
|
|
|||
| # get PR file list, filter out removed files, filter only JS/TS files, then pass to the linter | |||
| curl -fsSL https://api.github.com/repos/$PROJECT_USERNAME/$REPO_NAME/pulls/$PR_NUM/files | jq -r '.[] | select(.status!="removed") | .filename' | grep -E '\.(js|jsx|ts|tsx)$' || true | xargs yarn eslint | |||
| curl -fsSL https://api.github.com/repos/$PROJECT_USERNAME/$REPO_NAME/pulls/$PR_NUM/files | jq -r '.[] | select(.status!="removed") | .filename' | (grep -E '\.(js|jsx|ts|tsx)$' || true) | xargs yarn eslint --quiet | |||
There was a problem hiding this comment.
The parenthesis is required here. Otherwise it won't emit the lint error. Also the --quiet is added to silent the lint warnings, which is the same as the previous CCI behavior for codegen
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 85.93% 85.93%
=======================================
Files 152 152
Lines 7489 7489
Branches 1956 1956
=======================================
Hits 6436 6436
Misses 960 960
Partials 93 93 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phani-srikar
approved these changes
Jul 13, 2023
dpilch
approved these changes
Jul 13, 2023
alharris-at
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Run the cleanup workflow in beta accounts
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.