fix: use pinned api category version until CDK bump is complete #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phani-srikar
approved these changes
Jul 12, 2023
AaronZyLee
approved these changes
Jul 12, 2023
|
I think this is no longer necessary. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently a subset of e2e tests are failing due to the in-flight migration from CDK 2.68.0 to 2.80.0 in CLI. This is because CLI has a caret dep on the API category packages (which we probably shouldn't do) so when installing CLI-internal we're getting the latest minor version of API cateogyr, that has the newer references to CDK 2.80, but cli-internal does not. For reasons that are not yet super clear, mixing cdk versions across the CLI causes issues, and while that's not ideal, it's not the issue we're solving here, we just want a consistent state of the world for codegen e2e testing.
This is blocking verification of dependabot fixes,etc.
Issue #, if available
N/A
Description of how you validated changes
Unit + E2E Tests https://app.circleci.com/pipelines/github/aws-amplify/amplify-codegen/3595/workflows/e697bd1f-b25e-4874-bbc4-ea05bf67606f
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.