Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ModelIdentifier for all Java models #612

Merged
merged 6 commits into from
Jun 29, 2023

Conversation

tylerjroach
Copy link
Member

@tylerjroach tylerjroach commented Jun 27, 2023

Description of changes

If CPK flag is enabled:

  • We will now create a T: ModelIdentifier for all models (not just cpk with sort keys)
  • resolveIdentifier will only return the ModelIdentifier if cpk + sort key
  • deprecation warning for resolveIdentifier as it is only intended to be used internally in Amplify

All changes are additive (non-breaking)

Description of how you validated changes

  • Added snapshot tests for new scenarios

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach
Copy link
Member Author

Marking as draft until improvements are fully staged in Amplify Android.

@codecov-commenter
Copy link

Codecov Report

Merging #612 (3865fb8) into main (21bbff8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   85.92%   85.91%   -0.01%     
==========================================
  Files         152      152              
  Lines        7493     7492       -1     
  Branches     1959     1958       -1     
==========================================
- Hits         6438     6437       -1     
  Misses        962      962              
  Partials       93       93              
Impacted Files Coverage Δ
...delgen-plugin/src/visitors/appsync-java-visitor.ts 94.79% <100.00%> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tylerjroach tylerjroach marked this pull request as ready for review June 28, 2023 19:33
@tylerjroach tylerjroach requested a review from a team as a code owner June 28, 2023 19:33
Copy link

@manueliglesias manueliglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dpilch dpilch merged commit 852b7b2 into main Jun 29, 2023
3 checks passed
@dpilch dpilch deleted the tjroach/modelidentifier-for-all-cpk branch June 29, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants