Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs express serverless function template #13194

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

ykethan
Copy link
Member

@ykethan ykethan commented Sep 7, 2023

Description of changes

update the aws-express-serverless to vendia/serverless-express in function nodejs templates Serverless ExpressJS function (Integration with API Gateway)

Adds e2e test to call API gateway

vendia repo
this was modified according to example

Issue #, if available

#10812

Description of how you validated changes

added tests to invoke the API and manually tested the API.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ykethan ykethan requested a review from a team as a code owner September 7, 2023 14:28
@@ -5,8 +5,7 @@
"main": "index.js",
"license": "Apache-2.0",
"dependencies": {
"aws-serverless-express": "^3.3.5",
"body-parser": "^1.17.1",
"@vendia/serverless-express": "^4.10.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we using 3rd party dependency for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws-serverless-express is being deprecated and rebranded to vendia
on the npm: On 11/30, the AWS Serverless Express library is moving to Vendia and will be rebranded to serverless-express. Similarly, the aws-serverless-express NPM package will be deprecated in favor of a new serverless-express package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants