Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: exclude custom tests on windows, bump memory on windows #13044

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Aug 1, 2023

Description of changes

This PR:

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner August 1, 2023 20:00
@sobolk sobolk changed the title chore: exclude custom tests on windows, bump memory on windows test: exclude custom tests on windows, bump memory on windows Aug 1, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #13044 (b53ecd0) into dev (ec9a2ba) will increase coverage by 48.45%.
Report is 281 commits behind head on dev.
The diff coverage is 59.37%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##              dev   #13044       +/-   ##
===========================================
+ Coverage    0.00%   48.45%   +48.45%     
===========================================
  Files        1296      842      -454     
  Lines      149743    38038   -111705     
  Branches     1296     7789     +6493     
===========================================
+ Hits            0    18432    +18432     
+ Misses     148447    18016   -130431     
- Partials     1296     1590      +294     
Files Changed Coverage Δ
...rmation/auth-stack-builder/auth-stack-transform.ts 91.30% <0.00%> (+91.30%) ⬆️
...tack-builder/auth-user-pool-group-stack-builder.ts 51.72% <ø> (+51.72%) ⬆️
...h-stack-builder/user-pool-group-stack-transform.ts 94.59% <0.00%> (+94.59%) ⬆️
.../src/provider-utils/awscloudformation/constants.ts 100.00% <ø> (+100.00%) ⬆️
...e-walkthrough-types/awsCognito-user-input-types.ts 100.00% <ø> (+100.00%) ⬆️
...vice-walkthrough-types/cognito-user-input-types.ts 100.00% <ø> (+100.00%) ⬆️
...y-category-function/src/commands/function/build.ts 0.00% <0.00%> (ø)
...ify-category-function/src/events/prePushHandler.ts 33.33% <0.00%> (+33.33%) ⬆️
...ider-utils/awscloudformation/utils/layerHelpers.ts 21.80% <0.00%> (+21.80%) ⬆️
...er-utils/awscloudformation/utils/storeResources.ts 30.38% <ø> (+30.38%) ⬆️
... and 58 more

... and 1243 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

/* TEMPORARY-PR12830: Remove after we ship PR12830 */
'src/__tests__/custom_resources.test.ts',
'src/__tests__/custom-resource-with-storage.test.ts',
/* END TEMPORARY */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's happening here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding missing piece of eba5625 .
I.e. we disabled these on CCI but not CB.

@@ -8,7 +8,7 @@ export MSYS2_ARG_CONV_EXCL="*"

export AMPLIFY_DIR=$CODEBUILD_SRC_DIR\\out
export AMPLIFY_PATH=$CODEBUILD_SRC_DIR\\out\\amplify.exe
export NODE_OPTIONS=--max-old-space-size=4096
export NODE_OPTIONS=--max-old-space-size=5120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using an even-bigger number?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we run multiple test workers on machine, therefore increasing in steps as needed, so the chance they'll consume all available memory on VM is less.

Copy link
Contributor

@0618 0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolk sobolk merged commit df42899 into aws-amplify:dev Aug 1, 2023
3 checks passed
@sobolk sobolk deleted the exclude-cb-custom branch August 1, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants