-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: exclude custom tests on windows, bump memory on windows #13044
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #13044 +/- ##
===========================================
+ Coverage 0.00% 48.45% +48.45%
===========================================
Files 1296 842 -454
Lines 149743 38038 -111705
Branches 1296 7789 +6493
===========================================
+ Hits 0 18432 +18432
+ Misses 148447 18016 -130431
- Partials 1296 1590 +294
... and 1243 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/* TEMPORARY-PR12830: Remove after we ship PR12830 */ | ||
'src/__tests__/custom_resources.test.ts', | ||
'src/__tests__/custom-resource-with-storage.test.ts', | ||
/* END TEMPORARY */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's happening here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding missing piece of eba5625 .
I.e. we disabled these on CCI but not CB.
@@ -8,7 +8,7 @@ export MSYS2_ARG_CONV_EXCL="*" | |||
|
|||
export AMPLIFY_DIR=$CODEBUILD_SRC_DIR\\out | |||
export AMPLIFY_PATH=$CODEBUILD_SRC_DIR\\out\\amplify.exe | |||
export NODE_OPTIONS=--max-old-space-size=4096 | |||
export NODE_OPTIONS=--max-old-space-size=5120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using an even-bigger number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we run multiple test workers on machine, therefore increasing in steps as needed, so the chance they'll consume all available memory on VM is less.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of changes
This PR:
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.