Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix layer e2e, env name has 10 character limit #13021

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

jhockett
Copy link
Contributor

@jhockett jhockett commented Jul 28, 2023

Description of changes

This PR fixes the failing layer-1.test.ts e2e test due to the environment name being too long

Issue #, if available

https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/22457/workflows/f59c5276-1241-40b8-a6a5-8cd0f2b85d40/jobs/1038177

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jhockett jhockett requested a review from a team as a code owner July 28, 2023 01:46
Copy link
Member

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

Codecov Report

Merging #13021 (d457bdc) into dev (ec9a2ba) will increase coverage by 48.45%.
Report is 270 commits behind head on dev.
The diff coverage is 58.79%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##              dev   #13021       +/-   ##
===========================================
+ Coverage    0.00%   48.45%   +48.45%     
===========================================
  Files        1296      842      -454     
  Lines      149743    38038   -111705     
  Branches     1296     7789     +6493     
===========================================
+ Hits            0    18432    +18432     
+ Misses     148447    18016   -130431     
- Partials     1296     1590      +294     
Files Changed Coverage Δ
...rmation/auth-stack-builder/auth-stack-transform.ts 91.30% <0.00%> (+91.30%) ⬆️
...tack-builder/auth-user-pool-group-stack-builder.ts 51.72% <ø> (+51.72%) ⬆️
...h-stack-builder/user-pool-group-stack-transform.ts 94.59% <0.00%> (+94.59%) ⬆️
.../src/provider-utils/awscloudformation/constants.ts 100.00% <ø> (+100.00%) ⬆️
...e-walkthrough-types/awsCognito-user-input-types.ts 100.00% <ø> (+100.00%) ⬆️
...vice-walkthrough-types/cognito-user-input-types.ts 100.00% <ø> (+100.00%) ⬆️
...y-category-function/src/commands/function/build.ts 0.00% <0.00%> (ø)
...ify-category-function/src/events/prePushHandler.ts 33.33% <0.00%> (+33.33%) ⬆️
...ider-utils/awscloudformation/utils/layerHelpers.ts 21.80% <0.00%> (+21.80%) ⬆️
...er-utils/awscloudformation/utils/storeResources.ts 30.38% <ø> (+30.38%) ⬆️
... and 69 more

... and 1229 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sobolk sobolk merged commit 3e08fb9 into aws-amplify:dev Jul 28, 2023
3 checks passed
@jhockett jhockett deleted the layer-1-e2e-fix branch July 28, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants