Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql): change delta table pk format for cpk #594

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sundersc
Copy link
Contributor

@sundersc sundersc commented Jun 25, 2022

Description of changes

This PR changes the delta table partition key format for better sync performance with models having custom primary key. New attributes are added to mutations and sync queries resolvers to notify AppSync to use the newly improved data format.

Issue #, if available

#1798

Description of how you validated changes

  • yarn test
  • new e2e test
  • manual test

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sundersc sundersc requested a review from a team as a code owner June 25, 2022 20:52
@sundersc sundersc marked this pull request as draft June 25, 2022 20:52
@lgtm-com
Copy link

lgtm-com bot commented Jun 25, 2022

This pull request introduces 1 alert when merging f7fc30b into f993270 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov-commenter
Copy link

Codecov Report

Merging #594 (b886bb4) into main (6a7b9f3) will increase coverage by 0.17%.
The diff coverage is 65.62%.

@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   63.14%   63.31%   +0.17%     
==========================================
  Files         278      282       +4     
  Lines       18125    18373     +248     
  Branches     4375     4461      +86     
==========================================
+ Hits        11445    11633     +188     
- Misses       6093     6129      +36     
- Partials      587      611      +24     
Impacted Files Coverage Δ
...-graphql-auth-transformer/src/utils/definitions.ts 100.00% <ø> (ø)
...on-transformer/src/graphql-function-transformer.ts 93.54% <ø> (ø)
...l-http-transformer/src/graphql-http-transformer.ts 96.21% <ø> (ø)
...searchable-transformer/src/cdk/create-cfnOutput.ts 100.00% <ø> (ø)
...ql-transformer-core/src/cdk-compat/nested-stack.ts 10.20% <ø> (ø)
...ql-transformer-core/src/cdk-compat/schema-asset.ts 65.21% <ø> (ø)
...transformer-core/src/transformer-context/output.ts 2.43% <0.00%> (-0.35%) ⬇️
...graphql-transformer-core/src/utils/schema-utils.ts 18.18% <0.00%> (-4.55%) ⬇️
...graphql-elasticsearch-transformer/src/resources.ts 100.00% <ø> (ø)
packages/graphql-transformer-core/src/index.ts 97.29% <ø> (ø)
... and 70 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants