chore: bump cross-spawn version to be at least 7.0.5 #3031
Closed
+1,486
−1,915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejas2008
approved these changes
Nov 18, 2024
dpilch
reviewed
Nov 18, 2024
| @@ -3991,7 +3991,7 @@ | |||
| "stability": "stable" | |||
| }, | |||
| "homepage": "https://github.com/aws-amplify/amplify-category-api.git", | |||
| "jsiiVersion": "5.5.4 (build 1378d94)", | |||
| "jsiiVersion": "5.6.0 (build 7be6ace)", | |||
There was a problem hiding this comment.
Why is the JSII version changing?
There was a problem hiding this comment.
I merged changes from main, then I ran yarn build and yarn test. The JSII version change appears after running yarn build.
There was a problem hiding this comment.
It probably shouldn't be changing from modifying the husky version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR is to fix this dependabot alert. In shot,
cross-spawnis used byhuskyand needs to be bumped to be higher than7.0.5for a security patch.huskyto^5.0.0andcross-spawnto7.0.6.CDK / CloudFormation Parameters Changed
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.