Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto increment support #2883
base: main
Are you sure you want to change the base?
feat: auto increment support #2883
Changes from all commits
d7583df
3a14876
5c05668
e25b75f
c9c6013
f2e350b
978079a
89f3fd3
2e5eebd
50db9e8
12d5f28
1824129
ba88154
f6f18b9
47caabf
b929519
37c7198
f0adbce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth nothing in a comment here the important characteristics of this tests:
Int
field, backed by aSERIAL
type in PG@default
annotation with no arguments, meaning that the only behavior our transformer should do is to suppress the input requirement.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted in comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now or in the next PR: Can we migrate this test to use the configurable stack so we can (eventually) remove the
sql-models
stack? Eventually I'd like us to be using just one stack to reduce the number of test fixtures we have to maintain.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's okay I'd like to defer this migration to a separate PR and migrate a number of tests at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does PG allow someone to specify a value for a
SERIAL
field? If so, we need a test for that case. If not, we need a test that a customer cannot supply a value for it (which might just be a unit test that asserts the serial default field is not present in the input shape.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PG does allow users to specify a value for
SERIAL
fields (but does not stop users' sequences from reproducing that value later). I modified the test to use a custom value for one of the inserts.