fix: treating id field as implicit primary key which we miss today #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phani-srikar
commented
Nov 1, 2023
codebuild_specs/e2e_workflow.yml
Outdated
| @@ -135,24 +135,24 @@ batch: | |||
| CLI_REGION: us-east-1 | |||
| depend-on: | |||
| - publish_to_local_registry | |||
| - identifier: api_1_resolvers_sync_query_datastore_api_6 | |||
| - identifier: rds_pg_refersTo_api_1_resolvers_sync_query_datastore | |||
There was a problem hiding this comment.
This will go away once my other commit shows up on Github. I pushed it but its not there yet for some reason.
alharris-at
reviewed
Nov 2, 2023
Comment on lines
+1012
to
+1017
| type Song @model { | ||
| id: ID! | ||
| name: String! | ||
| genre: String! | ||
| } | ||
| `; |
There was a problem hiding this comment.
Can we add a suite of tests that validates the entire app generated for this schema is the same as what is generated if there's an explicit @primaryKey on id? That'd give me more confidence that we're doing the right thing across all transformers in concert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The primary key transformer does not recognize the default
id: ID!field on a model as implicit primary key and hence does not generate any resolvers for that field. One of the issues arising this is that thepreAuthslot for Sync Queries is not generated which causes the Sync to be slow as it scans the whole table even if the filter is specified on theidfield by the customers. Other side effects include missingpre-Authslots that set the primary key information for CRUD operation resolvers for the models.Please see the snapshot changes for the full change set.
This could be a breaking change since we're generating several new resolver slots and their overall evaluation might break existing apps.
CDK / CloudFormation Parameters Changed
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.