Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/graph ql transformer core added bracket mismatch detection #1138

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

ncarvajalc
Copy link
Contributor

Description of changes

Added border case for feature added in #107 in which this line was not valid:

# ["asdf"]

Issue #, if available

#107

Description of how you validated changes

Modified existing test case and yarn test succesfully.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ncarvajalc and others added 14 commits November 8, 2022 11:55
Created a new error that handles whenever the schema has a bracket
mismatch

✅ Closes: aws-amplify#107
Added extra validation and more specific error message to address
bracket syntax issues in schema

✅ Closes: aws-amplify#107
Added extra error case in case there is an extra bracket in the schema

✅ Closes: aws-amplify#107
…-api into feat/graph-ql-transformer-core-added-bracket-mismatch-detection
Added fallback to switch cases as suggested

✅ Closes: aws-amplify#107
add tests for valid, missing bracket, and extra bracket schemas

✅ Closes: aws-amplify#107
Added to the error message the line number in which the bracket mismatch
ocurrs

✅ Closes: aws-amplify#107
Update bracket validation function to prevent mismatched brackets inside
of comments from throwing error

✅ Closes: aws-amplify#107
Added the case in which there is a bracket mismatch or a hash inside of
a string

✅ Closes: aws-amplify#107
Removed useless condition pointed out by lgtm

✅ Closes: aws-amplify#107
Refactored bracket mismatch cases

✅ Closes: aws-amplify#107
…-api into feat/graph-ql-transformer-core-added-bracket-mismatch-detection
 Fixed a border case in which # ["asdf"] was not a valid line

✅ Closes: aws-amplify#107
@ncarvajalc ncarvajalc requested a review from a team as a code owner January 4, 2023 23:57
@phani-srikar
Copy link
Contributor

phani-srikar commented Jan 5, 2023

I think you need to rebase your changes with main after updating the main branch in your fork with upstream main.

jcollinc and others added 7 commits January 4, 2023 21:00
Added extra validation and more specific error message to address
bracket syntax issues in schema

✅ Closes: aws-amplify#107
Added extra error case in case there is an extra bracket in the schema

✅ Closes: aws-amplify#107
Added fallback to switch cases as suggested

✅ Closes: aws-amplify#107
Added to the error message the line number in which the bracket mismatch
ocurrs

✅ Closes: aws-amplify#107
Update bracket validation function to prevent mismatched brackets inside
of comments from throwing error

✅ Closes: aws-amplify#107
 Fixed a border case in which # ["asdf"] was not a valid line

✅ Closes: aws-amplify#107
…etection' of https://github.com/ncarvajalc/amplify-category-api into feat/graph-ql-transformer-core-added-bracket-mismatch-detection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants