Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fips option #602

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

devon-manifest
Copy link

Issue #, if available:
#401

Description of changes:
Adds an optional use-fips-endpoint input. If this input is set to true, the ECR client configuration will include useFipsEndpoint: true (allowing authentication token generation and docker login to the ecr-fips variant of the ECR registry).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Add use-fips-endpoint input to actions.yml and index.js
- Assemble ECR config once and pass it to wrapper functions
- Add use-fips-endpoint input to existing tests
@dotCipher
Copy link

@arjraman, not sure who to tag for these, but who would review this? Would be super helpful 👍🏻

@chicagobuss
Copy link

we would love this as well - bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants