Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom block data null in v3.2.13 #274

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix: custom block data null in v3.2.13 #274

merged 1 commit into from
Dec 21, 2023

Conversation

phuongvietvu0306
Copy link
Contributor

related to issue #271

@phuongvietvu0306 phuongvietvu0306 mentioned this pull request Dec 21, 2023
Closed
@awcodes
Copy link
Owner

awcodes commented Dec 21, 2023 •
edited
Loading

Can you verify that this still works with content/data that has single quotes in it please.

@phuongvietvu0306
Copy link
Contributor Author

phuongvietvu0306 commented Dec 21, 2023 •
edited
Loading

I dont write unit test yet but here are screenshots of my manual testcase I can think of
Still works with single/double quote and newline break (\n)

Screenshot with browser inspection:
Screen Shot 2023-12-21 at 21 16 00

Screenshot when open modal to update:
Screen Shot 2023-12-21 at 21 17 59

Screenshot of database:
Screen Shot 2023-12-21 at 21 16 22

@awcodes
Copy link
Owner

awcodes commented Dec 21, 2023

Thanks.

@awcodes awcodes merged commit 60d5840 into awcodes:3.x Dec 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phuongvietvu0306 @awcodes