Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fixes #520

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Proposed fixes #520

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2020

No description provided.

Milou Brand added 3 commits October 22, 2020 15:44
*removed silly comments
*removed silly comments
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@ead0038). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #520   +/-   ##
=========================================
  Coverage          ?   60.07%           
=========================================
  Files             ?       30           
  Lines             ?     7023           
  Branches          ?        0           
=========================================
  Hits              ?     4219           
  Misses            ?     2804           
  Partials          ?        0           
Impacted Files Coverage Δ
R/WorkbookClass.R 55.49% <100.00%> (ø)
R/loadWorkbook.R 69.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead0038...f0767ad. Read the comment docs.

@ycphs
Copy link
Contributor

ycphs commented Oct 27, 2020

Could you please provide this PR also to ycphs/openxlsx?

I am maintaining the active fork of the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant