Codebase cleanup #917
Open
Codebase cleanup #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headers don't need executable bits set, especially if it is only done on a handful. Lets drop them. Signed-off-by: Olliver Schinagl <[email protected]>
Having the signature defined outside of the ifguard is probably not a good idea anyway. Signed-off-by: Olliver Schinagl <[email protected]>
We should avoid "already included" errors where we can. Signed-off-by: Olliver Schinagl <[email protected]>
Just whitespace changes, no code changes where performed. Most where caught with `git --no-pager log --check --oneline master..HEAD`, something that can be caught in the future in the CI, where 'master' would be replaced with the source branch. Signed-off-by: Olliver Schinagl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small series that cleans up some obvious sloppyness. Nothing special was used to find these, just vim being told to fix trailing whitespaces on save.
While doing so, a few somewhat obvious issues where discovered and fixed, which should not trigger code changes, just (now removed) warnings on duplication.
In the future, this could be caught with a CI pipline that runs
git --no-pager log --check --oneline master..HEAD, something that can be caught in the future in the CI, where 'master' would be replaced with the source branch, usually a variable in the CI.There still exists a lot of glaring whitespace violations in the code base, but I let this series be focused on the obvious and easy to fix ones. Though a script could be used to fix any 'tab and space' mixed indents in the future.