Fixed __ATTR_PROGMEM__ by utilizing the variant available in clang #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprintersb
reviewed
Sep 16, 2022
sprintersb
reviewed
Sep 23, 2022
| @@ -95,8 +95,18 @@ | |||
| #endif | |||
|
|
|||
| #ifndef __ATTR_PROGMEM__ | |||
| #if defined __has_attribute | |||
| #if __has_attribute(__progmem__) | |||
There was a problem hiding this comment.
That won't work either when !__has_attribute, because then PROGMEM will not be defined. Why not just leave the GCC stuff untouched and do you clang stuff? Like:
#ifndef __ATTR_PROGMEM__
#ifdef __clang_version__
/* do clang stuff */
#else
#define __ATTR_PROGMEM__ __attribute__((__progmem__))
#endif
#endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#55921 (comment)