allow to remove attribute during update product.

avored · Mar 24, 2017 · 4f6b033 · 4f6b033
1 parent 1e202d2
commit 4f6b033
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/modules/base/Mage2/Catalog/Helpers/ProductHelper.php b/modules/base/Mage2/Catalog/Helpers/ProductHelper.php
@@ -173,12 +173,16 @@ public function saveProductAttribute($product, ProductRequest $request)
                 }
             }
 
-            foreach(array_flip($existingIds) as $id) {
-                ProductVariation::destroy($id);
+            if(count($existingIds)>0) {
+                foreach (array_flip($existingIds) as $id) {
+                    ProductVariation::destroy($id);
+                }
             }
 
+        } else {
 
-
+            //only needed when remove all attribute using remove icon during edit product
+            $product->update(['has_variation' => 0]);
         }
 
 

diff --git a/modules/base/Mage2/Catalog/Models/Product.php b/modules/base/Mage2/Catalog/Models/Product.php
@@ -56,7 +56,7 @@ public function getAssignedAttributes() {
             return $productVariationsList->unique('product_attribute_id');
         }
 
-        return null;
+        return [];
 
     }
 

diff --git a/modules/base/Mage2/Catalog/views/admin/catalog/product/attribute.blade.php b/modules/base/Mage2/Catalog/views/admin/catalog/product/attribute.blade.php
@@ -10,7 +10,6 @@
         <?php
 
         $attributes = $product->getAssignedAttributes();
-
         //todo How does multiple Variation works
         //$firstVariation = $product->productVariations()->get()->first();
         //$attribute = $firstVariation->productAttribute;
-Original file line number
+Diff line change
@@ Expand Up / @@ -56,7 +56,7 @@ public function getAssignedAttributes() { @@
                 return $productVariationsList->unique('product_attribute_id');
             }
-            return null;
+            return [];
         }
@@ Expand Down @@