Deprecate methods from threading module #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YongxueHong @lkotek @yanan-fu would you mind to help review this one? thanks in advance! |
yanan-fu
approved these changes
Feb 1, 2024
|
For the python 3.7 checking failure, as avocado have drop the python 3.7 with :avocado-framework/avocado@a17bfff Do we need to update the ci accordingly in avocado-vt with a separate commit or patch now ? avocado-vt/.github/workflows/ci.yml Line 37 in 9485fc6 |
yanan-fu
approved these changes
Feb 1, 2024
|
Eh~ I missed #3832 and it just be merged. So python 3.7 CI checking failure issue has gone . |
There are a few threading methods been deprecated since Python3.10, let's replace them according to the guide. Reference: https://docs.python.org/3/whatsnew/3.10.html#deprecated Issue: avocado-framework#3837 Signed-off-by: Xu Han <[email protected]>
luckyh
force-pushed
the
update-threading-names
branch
from
1a56744
to
e82b82c
Compare
YongxueHong
approved these changes
Feb 4, 2024
|
I checked with the python docs, I don't see any issue here. Thanks for the patch! Ack |
|
Thanks to all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few threading methods been deprecated since Python3.10, let's replace them according to the guide.
Reference: https://docs.python.org/3/whatsnew/3.10.html#deprecated
Issue: #3837
ID: 1791