-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tags field in select mode #3603
Conversation
Code Climate has analyzed commit b5711ad and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
rubocop
spec/system/avo/tags_spec.rb|277 col 37| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|277 col 57| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/system/avo/tags_spec.rb|299 col 29| [Corrected] Layout/SpaceInsideBlockBraces: Space missing inside {.
spec/system/avo/tags_spec.rb|299 col 38| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|299 col 53| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|299 col 75| [Corrected] Layout/SpaceInsideBlockBraces: Space missing inside }.
spec/system/avo/tags_spec.rb|301 col 14| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/system/avo/tags_spec.rb|301 col 22| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|301 col 37| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|301 col 57| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/system/avo/tags_spec.rb|302 col 14| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/system/avo/tags_spec.rb|302 col 22| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|302 col 37| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|302 col 57| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/system/avo/tags_spec.rb|303 col 14| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/system/avo/tags_spec.rb|303 col 22| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|303 col 37| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|303 col 57| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
This PR has been merged into Please check the release guide for more information. |
Description
Fixes #3601
This PR is fixing tags field on select mode when using hash with
label
andvalue
keysChecklist: