Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tags field in select mode #3603

Merged
merged 8 commits into from
Jan 22, 2025
Merged

fix: tags field in select mode #3603

merged 8 commits into from
Jan 22, 2025

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jan 21, 2025

Description

Fixes #3601

This PR is fixing tags field on select mode when using hash with label and value keys

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob marked this pull request as draft January 21, 2025 16:17
@github-actions github-actions bot added the Fix label Jan 21, 2025
Copy link

codeclimate bot commented Jan 21, 2025

Code Climate has analyzed commit b5711ad and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob self-assigned this Jan 22, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

rubocop

spec/system/avo/tags_spec.rb|277 col 37| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|277 col 57| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/system/avo/tags_spec.rb|299 col 29| [Corrected] Layout/SpaceInsideBlockBraces: Space missing inside {.
spec/system/avo/tags_spec.rb|299 col 38| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|299 col 53| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|299 col 75| [Corrected] Layout/SpaceInsideBlockBraces: Space missing inside }.
spec/system/avo/tags_spec.rb|301 col 14| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/system/avo/tags_spec.rb|301 col 22| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|301 col 37| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|301 col 57| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/system/avo/tags_spec.rb|302 col 14| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/system/avo/tags_spec.rb|302 col 22| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|302 col 37| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|302 col 57| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/system/avo/tags_spec.rb|303 col 14| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/system/avo/tags_spec.rb|303 col 22| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|303 col 37| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/tags_spec.rb|303 col 57| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.

spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
@Paul-Bob Paul-Bob marked this pull request as ready for review January 22, 2025 15:11
@Paul-Bob Paul-Bob merged commit 565851b into main Jan 22, 2025
20 checks passed
@Paul-Bob Paul-Bob deleted the fix/tags_field_in_select_mode branch January 22, 2025 15:39
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tags field in select mode breaks
1 participant